Re: [Po4a-devel] Dealing with series of comments in the XML module

From: Nicolas François <nicolas.francois at centraliens.net> Subject: Re: [Po4a-devel] Dealing with series of comments in the XML module Date: Fri, 29 Feb 2008 18:21:37 +0100 > > Test data for the XML module contain > > > > <!-- The content of this document is licensed under the XXX license --> > > <!-- See bla bla --> > > > > as an input data and > > > > <!-- The content of this document is licensed under the XXX license > > See bla bla --> > > > > as its corresponding output data. Does this mean that the conversion > > of a series of comments into one comment is an expected behavior? > > > > Since the Wml module temporarily converts '#'-headed comments into an > > XML-syntax comments and uses the XML module for parsing, the > > conversion of a series of comments results in a bug. I'd like to know > > whether this should be fixed in the XML module or in the Wml > > module. ;-) > > This was currently not an issue in the Xml module, but if it is a limitation > for the Wml module, it can be changed (I don't think any module or user > rely on it). > I think it can be fixed in the translate_paragraph subroutine of the Xml > module (before the first pushline) Thank you for polite suggestions! I'll try to fix. > The goal is just to check how it evolves, but if the resulting translated > document changes, and if it looks more like the original comments, then > it's better. > Just update the testsuite when you update the Xml module.