6:47 a.m.
Hello guys,
First, i would like to congrats developers for this fantastic
tool.
I've started using po4a few weeks ago, and yesterday i had
this problem. After generate a .po file with po4a-gettextize
I realized it added the CDATA end sequence ']]' to msgid.
Is it an expected behaviour?
If yes, i think it's dangerous, because if translator remove
this from translated string, the new xml created with
po4a-translate will be broken.
I filled a bug on po4a Tracker [1].
I would be glad to help testing a possible solution for this,
and since i'm maintainer of po4a on FreeBSD ports, i can
add patches to fix this problem there too.
Regards
[1] -
http://alioth.debian.org/tracker/index.php?func=detail&aid=312773&...
--
Renato Botelho
7:07 a.m.
New subject: [Po4a-devel] CDATA end sequence added to msgid
On 2010/10/19 Renato Botelho wrote:
Hello guys,
First, i would like to congrats developers for this fantastic
tool.
I've started using po4a few weeks ago, and yesterday i had
this problem. After generate a .po file with po4a-gettextize
I realized it added the CDATA end sequence ']]' to msgid.
Is it an expected behaviour?
Hello Renato,
I agree that this behaviour has to be fixed.
Here is a patch.
Denis
7:12 a.m.
New subject: [Po4a-devel] CDATA end sequence added to msgid
On Tue, Oct 19, 2010 at 10:07 AM, Denis Barbier <bouzim(a)gmail.com> wrote:
On 2010/10/19 Renato Botelho wrote:
> Hello guys,
>
> First, i would like to congrats developers for this fantastic
> tool.
>
> I've started using po4a few weeks ago, and yesterday i had
> this problem. After generate a .po file with po4a-gettextize
> I realized it added the CDATA end sequence ']]' to msgid.
>
> Is it an expected behaviour?
Hello Renato,
I agree that this behaviour has to be fixed.
Here is a patch.
I tried this change before open ticket, it has a problem
because it understand the line that just contain a string
like this:
]]>
as a new msgid.
I also tried to change include=0 on get_string_until()
call inside CDATA_extract, and it worked better. But
it's not enough because after changing this
po4a-translate didn't translate this string anymore.
I think the change is a bit more complex than this, but
I don't know the code enough yet to implement it right
now.
Thanks anyway
--
Renato Botelho
7:26 a.m.
New subject: [Po4a-devel] CDATA end sequence added to msgid
On 2010/10/19 Renato Botelho wrote:
On Tue, Oct 19, 2010 at 10:07 AM, Denis Barbier
<bouzim(a)gmail.com> wrote:
> On 2010/10/19 Renato Botelho wrote:
>> Hello guys,
>>
>> First, i would like to congrats developers for this fantastic
>> tool.
>>
>> I've started using po4a few weeks ago, and yesterday i had
>> this problem. After generate a .po file with po4a-gettextize
>> I realized it added the CDATA end sequence ']]' to msgid.
>>
>> Is it an expected behaviour?
>
> Hello Renato,
>
> I agree that this behaviour has to be fixed.
> Here is a patch.
I tried this change before open ticket, it has a problem
because it understand the line that just contain a string
like this:
]]>
as a new msgid.
I cannot reproduce it here, can you please provide a very simple test case?
Denis
7:42 a.m.
New subject: [Po4a-devel] CDATA end sequence added to msgid
On Tue, Oct 19, 2010 at 10:26 AM, Denis Barbier <bouzim(a)gmail.com> wrote:
On 2010/10/19 Renato Botelho wrote:
> On Tue, Oct 19, 2010 at 10:07 AM, Denis Barbier <bouzim(a)gmail.com> wrote:
>> On 2010/10/19 Renato Botelho wrote:
>>> Hello guys,
>>>
>>> First, i would like to congrats developers for this fantastic
>>> tool.
>>>
>>> I've started using po4a few weeks ago, and yesterday i had
>>> this problem. After generate a .po file with po4a-gettextize
>>> I realized it added the CDATA end sequence ']]' to msgid.
>>>
>>> Is it an expected behaviour?
>>
>> Hello Renato,
>>
>> I agree that this behaviour has to be fixed.
>> Here is a patch.
>
> I tried this change before open ticket, it has a problem
> because it understand the line that just contain a string
> like this:
>
> ]]>
>
> as a new msgid.
I cannot reproduce it here, can you please provide a very simple test case?
I really sorry for the noise. My eyes just made a trick with me and i
look the diff wrong.
The patch worked perfectly. I'll apply thins on FreeBSD ports.
Thank you for quick response.
--
Renato Botelho
7:48 a.m.
New subject: [Po4a-devel] CDATA end sequence added to msgid
On 2010/10/19 Renato Botelho:
On Tue, Oct 19, 2010 at 10:26 AM, Denis Barbier
<bouzim(a)gmail.com> wrote:
> On 2010/10/19 Renato Botelho wrote:
>> On Tue, Oct 19, 2010 at 10:07 AM, Denis Barbier <bouzim(a)gmail.com> wrote:
>>> On 2010/10/19 Renato Botelho wrote:
>>>> Hello guys,
>>>>
>>>> First, i would like to congrats developers for this fantastic
>>>> tool.
>>>>
>>>> I've started using po4a few weeks ago, and yesterday i had
>>>> this problem. After generate a .po file with po4a-gettextize
>>>> I realized it added the CDATA end sequence ']]' to msgid.
>>>>
>>>> Is it an expected behaviour?
>>>
>>> Hello Renato,
>>>
>>> I agree that this behaviour has to be fixed.
>>> Here is a patch.
>>
>> I tried this change before open ticket, it has a problem
>> because it understand the line that just contain a string
>> like this:
>>
>> ]]>
>>
>> as a new msgid.
>
> I cannot reproduce it here, can you please provide a very simple test case?
I really sorry for the noise. My eyes just made a trick with me and i
look the diff wrong.
The patch worked perfectly. I'll apply thins on FreeBSD ports.
Thank you for quick response.
Great, I'll apply this fix and add a test case.
Thanks for your report.
Denis
7:15 a.m.
New subject: [Po4a-devel] CDATA end sequence added to msgid
On Tue, Oct 19, 2010 at 10:07 AM, Denis Barbier <bouzim(a)gmail.com> wrote:
On 2010/10/19 Renato Botelho wrote:
> Hello guys,
>
> First, i would like to congrats developers for this fantastic
> tool.
>
> I've started using po4a few weeks ago, and yesterday i had
> this problem. After generate a .po file with po4a-gettextize
> I realized it added the CDATA end sequence ']]' to msgid.
>
> Is it an expected behaviour?
Hello Renato,
I agree that this behaviour has to be fixed.
Here is a patch.
Just do document, here is the patch I've made, it fixes
po4a-gettextize but break po4a-translate
--- Xml.pm.orig 2010-10-19 10:13:21.000000000 -0200
+++ Xml.pm 2010-10-19 10:13:35.000000000 -0200
@@ -903,7 +903,7 @@
sub CDATA_extract {
my ($self,$remove)=(shift,shift);
- my ($eof, @tag) =
$self->get_string_until(']]>',{include=>1,unquoted=>0,remove=>$remove});
+ my ($eof, @tag) =
$self->get_string_until(']]>',{include=>0,unquoted=>0,remove=>$remove});
return ($eof, @tag);
}
--
Renato Botelho
4931
days inactive
4931
days old
6 comments
2 participants
participants (2)
-
Denis Barbier -
Renato Botelho