Re: [Po4a-devel] Bug#827936: po4a: please implement support for Ruby document format
Control: tags -1 + patch
On Mon, 27 Mar 2017 09:15:38 +0200 Martin Quinson wrote:
On Sun, Mar 26, 2017 at 04:03:47PM +0200, Martin Quinson wrote:
> Hello,
Hi!
>
> it took me a while, but I had a look at your code, at least. Your new
> module seem very reasonnable to me, thank you.
Good, I am glad to read this.
>
> The thing is that I don't quite understand the tests. Could you please
> give your files sensible names? Have a look at how the AsciiDoc tests
> are organized: they are in t/data-30. You have a bunch of source
> files, one per feature set. And for each file you have a out and po
> files. All of these files are listed in t/30-asciidoc.t
>
> So you just have to "cp t/30-asciidoc.t t/31-rubydoc.t", edit
> t/31-rubydoc.t to change the asciidoc tests into rubydoc ones.
>
> if you have any issue with integrating your tests, I can certainly do
> that, but I'd need you to give sensible names to the test files, please.
I am attaching a full patch, with the new module, the new tests,
everything with respect to po4a version 0.51.
I hope this satisfies your expectations, since I have devoted a
quantity of spare time to it and it was not easy to find such time...
>
> Sorry for the latency, I'll try to be more responsive in the future.
>
In addition, you'll need the attached patch to integrate your module
to po4a and play with the test directory. It assumes that your Rd.pm
file is renamed as lib/Locale/Po4a/RubyDoc.pm (as it should).
These modifications are included in the patch I am sending right now.
Further actions yet to be performed:
* the new module should probably be added to t/01-classes.t
(could you please do it for me?)
* three new copyright lines should be added to debian/copyright
(please remember to do so; please note that my patch is released
under the terms of the GNU GPL v2 or later, just like most of po4a)
Copyright (c) 2016-2017 by Francesco Poli
<invernomuto(a)paranoici.org> Copyright (c) 2004 by MoonWolf
<moonwolf(a)moonwolf.com> Copyright (c) 2011-2012 by Youhei SASAKI
<uwabami(a)gfd-dennou.org>
* my patch is to be applied to the official version of po4a
(only you po4a developers can do that, so please accept it)
* a new version of po4a will have to be uploaded to Debian unstable
(please do so, when possible)
Thanks for your time and patience,
You're welcome.
Looking forward to seeing this new module accepted in po4a.
Bye!
--
http://www.inventati.org/frx/
There's not a second to spare! To the laboratory!
..................................................... Francesco Poli .
GnuPG key fpr == CA01 1147 9CD2 EFDF FB82 3925 3E1C 27E1 1F69 BFFE
Attachments:
- attachment.sig (application/pgp-signature — 833 bytes)
- add-rubydoc-module.diff.gz (application/gzip — 7.2 KB)