6:24 a.m.
On Fri, 15 Apr 2005, Martin Quinson wrote:
On Fri, Apr 15, 2005 at 01:18:51PM +0200, Jordi Vilalta wrote:
> Hi,
>
> while trying to translate the new website proposal I found the need to add
> module options in the config files (a longstanding limitation of the po4a
> script). A posible solution came to my mind: we could define "module
> aliases". For example, we could define po4aweb to be an alias to the xml
> module with some options:
>
> [po4a_alias: po4aweb] xml -o inline="<a>"
> [type: po4aweb] index.xml $lang:index.xml.$lang
>
> Would it be so difficult to implement it?
What about
[type: xml] index.xml $lang:index.xml.$lang modopt:inline="<a>"
?
It sounds rather simple to implement, too. It would solve the module option
issue, as long as you don't want to pass different module options for the
different languages.
The schema could be extended a bit for the other cases:
- language specific module option: modopt_fr and friends?
- non-module option such as -k to po4a-translate: no idea. Maybe directly:
[type: xml] index.xml $lang:index.xml.$lang modopt:inline="<a>" -k 40
Well, my idea was to be able to reuse the options. Once po4aweb is defined (in
the example above), there can be lots of documents using this "alias". Maybe we
could do a mix between both approaches: common options defined as module
aliases, and file-specific options defined in the file line.
We could use the same syntax (modopt and others) while defining the module
aliases, being able to do something like:
[po4a_alias: po4aweb] xml modopt:inline="<a>" opt:"-k 0" \
opt_fr:"-L iso-8859-1" opt_zh:"-L utf-8"
[type: po4aweb] index.xml $lang:index.xml.$lang
[type: po4aweb] features.xml $lang:features.xml.$lang modopt:inline="<b>"
Just brainstorming :P
Regards,
Jordi Vilalta
6 p.m.
New subject: [Po4a-devel]Config files enhancement
On Sun, Apr 17, 2005 at 01:24:07PM +0200, Jordi Vilalta wrote:
Well, my idea was to be able to reuse the options. Once po4aweb is
defined
(in the example above), there can be lots of documents using this "alias".
Maybe we could do a mix between both approaches: common options defined as
module aliases, and file-specific options defined in the file line.
OK, I was only thinking about the -o options.
So here is another implementation.
I was able to use:
[type:man] ../../chage.1 fr:fr/chage.1 add_fr:addendums/fr/chage.1.fr.add modopt:-L UTF-8
-v
[type:man] ../../chfn.1 fr:fr/chfn.1 add_fr:addendums/fr/addendum.fr modopt:-L latin-1
[type:man] ../../chpasswd.8 fr:fr/chpasswd.8 add_fr:addendums/fr/chpasswd.8.fr.add
modopt:-o debug=postrans
[type:man] ../../chsh.1 fr:fr/chsh.1 add_fr:addendums/fr/chsh.1.fr.add modopt:-o debug=0
[type:man] ../../dpasswd.8 fr:fr/dpasswd.8 add_fr:addendums/fr/addendum.fr
[type:man] ../../lastlog.8 fr:fr/lastlog.8 add_fr:addendums/fr/addendum.fr modopt:-k 0
However, I had to do a little modification on the initialize subroutine
from the man module:
As the man module uses a static variable to keep the options, this static
variable needs to be reset in initialize (other modules probably needs the
same correction). Otherwise, if you use -o debug=postrans, then all the
next files will inherit from this option without any way to disable it
Also, I had to add the verbose option to the man module in order to use
po4a -v <file>
(This is already in the CVS, but maybe some other modules need to be
fixed)
The main bug of this implementation is that it doesn't allow option
parameter with space to be set from the file. The handling of quotes
should be added later. BTW, if you know of any library which do that, it
may be interesting.
Also, I don't tested how options are overridden when they are set on the
command line and on the file.
We could use the same syntax (modopt and others) while defining the
module
aliases, being able to do something like:
[po4a_alias: po4aweb] xml modopt:inline="<a>" opt:"-k 0" \
opt_fr:"-L iso-8859-1" opt_zh:"-L utf-8"
[type: po4aweb] index.xml $lang:index.xml.$lang
[type: po4aweb] features.xml $lang:features.xml.$lang modopt:inline="<b>"
The attached implementation only allows a (or some) "modopt:" parameter.
However, it should be very simple to implement what you want (it is just a
matter of keeping the options, and appending all the relevant (the one
from the module, the one from the file and the one from the language)
options when needed.
Just let me know if it seems OK, and if I should commit it (after some
cleanups) before the release (it may need some testing).
Regards,
--
Nekral
8:01 p.m.
New subject: [Po4a-devel]Config files enhancement
Hello,
Here is an update of the patch.
It now deals with module aliases, with the ability to set global option
for this alias, or options for a language:
[po4a_alias:test] man opt="-k 0" opt_fr="-o debug -L ISO-8859-1"
Options can also be specified in a [type:...] line.
[type:test] chsh.1 fr:chsh.1.fr opt_fr:"-L UTF-8"
Limitations/known bugs:
* I don't know how options are overwritten.
(What should happen when the user specify -k 0 on the command line,
with -k 10 for the alias, -k 20 for the alias with lang=fr, -k 30 as
the file option, and -k 40 as the file option for lang=fr?)
* options have to be the last parameters on the line
(this limitation could be removed quite easily)
* it is not possible to specify the a value containing a space as the
parameter for a module option.
For example, users could use -o "foo=bar baz" on the command line.
This wont be possible with this implementation.
Any idea on how to fix this is welcome.
I'm considering committing it Saturday for the next release if you don't
stop me before.
It should be safe when options are not used, but options did not get a lot
of testing (and it has a great chance to have some bugs). Maybe it will
be an hidden/undocumented feature.
The patch mostly consists in:
* using an hash for the options (and a sub-hash for options passed to
the modules (-v, -d, -o).
* a function to fill this hash
* a function to separate
* aliases handling (an hash contains for each alias, the target module,
and the hash of options for this module)
Kind Regards
--
Nicolas
4:32 a.m.
New subject: [Po4a-devel]Config files enhancement
On Sat, Apr 23, 2005 at 03:01:43AM +0200, Nicolas François wrote:
Hello,
Here is an update of the patch.
It now deals with module aliases, with the ability to set global option
for this alias, or options for a language:
[po4a_alias:test] man opt="-k 0" opt_fr="-o debug -L ISO-8859-1"
Options can also be specified in a [type:...] line.
[type:test] chsh.1 fr:chsh.1.fr opt_fr:"-L UTF-8"
Limitations/known bugs:
* I don't know how options are overwritten.
(What should happen when the user specify -k 0 on the command line,
with -k 10 for the alias, -k 20 for the alias with lang=fr, -k 30 as
the file option, and -k 40 as the file option for lang=fr?)
* options have to be the last parameters on the line
(this limitation could be removed quite easily)
* it is not possible to specify the a value containing a space as the
parameter for a module option.
For example, users could use -o "foo=bar baz" on the command line.
This wont be possible with this implementation.
Any idea on how to fix this is welcome.
I'm not sure I see in the code were this comes from. I'd like to remove this
limitation, even if it's not a show stopper.
I'm considering committing it Saturday for the next release if
you don't
stop me before.
I'm glad nobody stopped you (I was away), it'a very good stuff as usual.
It should be safe when options are not used, but options did not get
a lot
of testing (and it has a great chance to have some bugs). Maybe it will
be an hidden/undocumented feature.
The patch mostly consists in:
* using an hash for the options (and a sub-hash for options passed to
the modules (-v, -d, -o).
* a function to fill this hash
* a function to separate
* aliases handling (an hash contains for each alias, the target module,
and the hash of options for this module)
I'll try to write the relevant documentation for this.
Thanks for your time,
Mt.
3:05 p.m.
New subject: [Po4a-devel]Config files enhancement
On Wed, Apr 27, 2005 at 11:32:42AM +0200, Martin Quinson wrote:
On Sat, Apr 23, 2005 at 03:01:43AM +0200, Nicolas François wrote:
> * it is not possible to specify the a value containing a space as the
> parameter for a module option.
> For example, users could use -o "foo=bar baz" on the command line.
> This wont be possible with this implementation.
> Any idea on how to fix this is welcome.
I'm not sure I see in the code were this comes from. I'd like to remove this
limitation, even if it's not a show stopper.
It is not really an implementation limitation, but a specification issue.
To specify -o foo=bar, an user can use opt:"-o foo=bar" (the quotes are
needed here because of the space between -o and foo=bar.
To specify -o "foo=bar baz", one would like to use opt:"-o "foo=bar
baz""
or use some escape for the internal quotes (escape is not supported,
IIRC).
The second issue is that I split the opt: parameter in order to fill the
@ARGV array and simulate what the shell does when somebody specify
-o "foo=bar baz" on the command line.
These issues can/should be fixed, but we should first agree on the syntax
for such cases.
BTW, do you know any Perl module that can split the command line?
(my current split(/ /, command) is really limited;)
I'll try to write the relevant documentation for this.
It may help: there are some examples in the test suite.
--
Nekral
7144
days inactive
7154
days old
4 comments
3 participants
participants (3)
-
Jordi Vilalta -
Martin Quinson -
Nicolas François