Re: [Po4a-devel]Some patches for the Man module

On Sun, Sep 26, 2004 at 06:03:54PM +0200, Nicolas François wrote: Done. You have the commit right. Please use it, but do not abuse it :) If you want we can stick to the current model for a while, where I review and commit your patches. But I gave you the cvs commit right so that at least trivial changes (such as the usage of the testsuite stuff) can go faster. I'd say: push it to the po file. The only issue is that it shows a flaw in po4a. Modules have no way [I could remember of] to push comments into the po file :-/ Ok, I've added one. It's not tested yet, but if you pass "comment" => "your_comment" at the end of the translate arguments, it should do the trick. Now, we should integrate this cleanly into the man module (having a variable dedicated to the storage of the comments, and used when pushing translations), but I don't want to interfer with your current changes in that file. If you test it yourself, the comments should end on lines begining with: #. Let's keep it on the todo for now. If you don't mind I'll let it maturate on your side. I've so little time myself... overiding shiftline could be a good idea. You may want to handle some parts of the chaos in a "upper layer". But please make sure to document this. Sounds very good to me. Simply change something like @toto = split(/\n/, $toto); foreach (@toto) {} to foreach (split(/\n/, $toto)) {} since @toto is used only once beside its initialization, it's useless. Of course, some times, you want to keep useless variables to make the code more readable. I don't felt it was the case here, but express yourself ;) I will try to do so more often, too. Ok, let's leave this one maturate, too. [...] [...] [..] Please do so, this one looks good too. Nope, it's not. But you had no way to know it. Btw, I commited all the others. For the sgml module, the policy is to include all the translations in only one po file, no matter how many source file there is. This is because it's very difficult to parse a sgml sub-file alone. Where it's included in the main document is important, as long as the entities defined in the prolog of the main document, and so on. So, I'd like to follow the same policy for the man pages. I know that it will result in dupplicate in the translations, but, well, translators can use compendiums. The prefered handling of .so is thus to read the included file, and then unshift all its lines (begining by the end, of course) into the transtractor. Of course, this should be a function of the TransTractor itself such as includefile($). But we didn't agree with Jordi on the function prototype and syntax before my vacations... Go ahead, dude. Commited with this explanation. Feel free to shorten it, it it keeps readable (or use /x, or both ;). I dunno. Now, it's commited as you said, and I dunno what could be the best. Keeping all the $wrapmode handling at the same location or all the .SH action at the same place. It's kinda the same. [again ;] That's the bounced part: Thanks so much for your work on po4a, Mt.